Skip to content

Unified pills and headers across Documentation #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 29, 2025
Merged

Unified pills and headers across Documentation #2705

merged 10 commits into from
Apr 29, 2025

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Apr 16, 2025 •
edited
Loading

Target: master, 4.6

Things done:

  • unified header sizes across the documentation after the new header design introduced in the Release Notes
  • unified pills look (as above)
  • added new edtion type: LTS Update and tagged LTS update pages with it

Examples:

Also the current doc had a bug where the inline pill was displayed slightly below the text:

  • Zrzut ekranu 2025-04-16 o 17 01 03
  • Zrzut ekranu 2025-04-16 o 17 01 48

(see https://doc.ibexa.co/en/latest/update_and_migration/from_4.5/update_from_4.5/#dashboard-migration )

This is now fixed.

@github-actions GitHub Actions
Copy link

Preview of modified Markdown:

@mnocon mnocon marked this pull request as ready for review April 17, 2025 09:02
adriendupuis
adriendupuis reviewed Apr 22, 2025
View reviewed changes
adriendupuis
adriendupuis requested changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pills don't have the exact same size, font and spacing everywhere.

@mnocon mnocon force-pushed the headers-pills-knees-toes branch from bc0b187 to 038e345 Compare April 24, 2025 08:40
@github-actions GitHub Actions
Copy link

Preview of modified files

Preview of modified Markdown:

@mnocon
Copy link
Contributor Author

mnocon commented Apr 24, 2025 •
edited
Loading

Thank you @adriendupuis , I've improved it in 038e345

  • I've used first-of-type so that it also matches the version pill in the top left:
    Zrzut ekranu 2025-04-24 o 12 01 07
  • align-self: center; for new pill fixes the alignment for longer entries, see:
    • before:
      Zrzut ekranu 2025-04-24 o 12 02 06
    • after:
      Zrzut ekranu 2025-04-24 o 12 02 15
  • I've changed the main.html as there were some invisible characters there, see https://doc.ibexa.co/en/latest/ibexa_engage/ibexa_engage/ for an example
    Zrzut ekranu 2025-04-24 o 12 04 03

@mnocon mnocon requested a review from adriendupuis April 24, 2025 10:04
@mnocon mnocon merged commit 2f27939 into master Apr 29, 2025
7 checks passed
@mnocon mnocon deleted the headers-pills-knees-toes branch April 29, 2025 09:54
mnocon added a commit that referenced this pull request Apr 29, 2025
@mnocon
Unified pills and headers across Documentation (#2705)
8f5dabb 
* Adjusted header size everywhere

* Extracted pill styling

* Unified header with release notes

* Added LTS update badhe

* Added default color for pill - latest pill on homepage

* New pill changes

* Selfreview

* New pill colors in PHP API ref

* Fixed inline styling

* Review fixes
@mnocon mnocon mentioned this pull request Apr 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriendupuis adriendupuis adriendupuis approved these changes

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

@dabrt dabrt Awaiting requested review from dabrt

Assignees
No one assigned
Labels
Needs DOC review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnocon @adriendupuis @julitafalcondusza